Skip to content

Conversation

dominikschubert
Copy link
Member

Previously we generated a list of all images which also included images such as localstack/localstack:<none>, i.e. dangling images without tags assigned.

Changes

  • Filter list of all images and removes any image names ending with :<none> before trying to update them.
  • Add new new image prefix to check for updates in images used by the lambda v2 provider (public.ecr.aws/lambda)

Closes #7156

@dominikschubert dominikschubert self-assigned this Feb 15, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests February 15, 2023 06:59 — with GitHub Actions Inactive
@github-actions
Copy link

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   1h 34m 24s ⏱️ + 6m 9s
1 710 tests  -   16  1 341 ✔️  -   27  368 💤 +  10  1 +1 
1 710 runs   - 730  1 341 ✔️  - 401  368 💤  - 330  1 +1 

For more details on these failures, see this check.

Results for commit 1e083ba. ± Comparison against base commit 14675b0.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! this is really helpful

@thrau thrau merged commit 029285d into master Feb 15, 2023
@thrau thrau deleted the update-ignore-dangling-images branch February 15, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: LocalStack CLI Update, flag all, should ignore dangling images
2 participants