Skip to content

refactor community ext imports #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2023
Merged

refactor community ext imports #7693

merged 4 commits into from
Feb 15, 2023

Conversation

alexrashed
Copy link
Member

This PR tries to decrease the coupling to our LocalStack Pro extensions.
It can only merged together with its companion PR.

The changes are separated in different commits:

  • remove DNS startup from community:
    • This commit removes the DNS startup from the edge.py. It will be started as a Pro plugin (infra start hook) instead.
      /cc @dfangl
  • refactor SSL cert handling:
  • unify, move, document ext imports:
    • Documents, moves, and unifies remaining (for now tolerated) ext imports.
  • migrate serve_flask_app to only remaining using module:
    • A somewhat unrelated refactoring, moving a legacy function from the generic proxy to its only using module (a legacy service provider).
      /cc @dominikschubert

@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 15, 2023 13:14 — with GitHub Actions Inactive
@alexrashed alexrashed marked this pull request as ready for review February 15, 2023 13:47
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 28m 53s ⏱️ - 1m 5s
1 726 tests ±0  1 368 ✔️ +1  358 💤  - 1  0 ❌ ±0 
2 440 runs  ±0  1 742 ✔️ +1  698 💤  - 1  0 ❌ ±0 

Results for commit ec76550. ± Comparison against base commit ec7f21d.

dominikschubert
dominikschubert reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked over the part for which you tagged me (lambda flask refactoring). Seems innocent enough with the move 👍

I'll leave the rest for @thrau though to approve.

thrau
thrau approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for untangling all this, will make it much easier to remove dead code.

@thrau thrau merged commit ce0f939 into master Feb 15, 2023
@thrau thrau deleted the remove-ext-imports branch February 15, 2023 23:37
@thrau thrau mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert left review comments

@thrau thrau thrau approved these changes

@dfangl dfangl Awaiting requested review from dfangl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @dominikschubert @thrau