Add support for route.destination-cidr-block filter in DescribeRouteTables #7700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
LGTM, thanks for the quick fix @dominikschubert! (based on @viren-nadkarni 's upstream PR) 🚀
viren-nadkarni
added a commit
that referenced
this pull request
Mar 7, 2023
This reverts commit 7159b90.
viren-nadkarni
added a commit
that referenced
this pull request
Mar 7, 2023
This reverts commit 7159b90.
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
route.destination-cidr-blockfilter inEC2.DescribeRouteTablesSee: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeRouteTables.html
Can be removed once https://github.com/getmoto/moto/pull/5932/files is merged upstream and we have updated our fork.