-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
improve apigw parity work for Resource proxy path #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d968ce6
to
47c5f27
Compare
4 tasks
47c5f27
to
48f01c1
Compare
calvernaz
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
835ca2a
to
36b13dc
Compare
48f01c1
to
b738462
Compare
a884dcd
to
2c801d5
Compare
2c801d5
to
900b216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving on to implement resource methods validation/removing patches, I've seen this page of the docs:
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-method-settings-method-request.html#api-gateway-proxy-resource
So I followed it to implement more validations on the previous PR #7738
Stumbled unto an interesting issue in the docs:
But it's not actually allowed, as the 2 last paths have a variable part, which will throw an exception. Implemented all the validations around this example in the docs.
Based on #7738
\cc @whummer