Skip to content

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 24, 2023

When moving on to implement resource methods validation/removing patches, I've seen this page of the docs:
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-method-settings-method-request.html#api-gateway-proxy-resource
So I followed it to implement more validations on the previous PR #7738

Stumbled unto an interesting issue in the docs:

An API can have more than one proxy resource. For example, the following proxy resources are allowed within an API.

/{proxy+}
/parent/{proxy+}
/parent/{child}/{proxy+}

But it's not actually allowed, as the 2 last paths have a variable part, which will throw an exception. Implemented all the validations around this example in the docs.

Based on #7738

\cc @whummer

@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from d968ce6 to 47c5f27 Compare February 24, 2023 15:58
@coveralls
Copy link

coveralls commented Feb 24, 2023

Coverage Status

Coverage: 85.119% (+0.02%) from 85.102% when pulling 900b216 on apigw-parity-work-res-proxy into 0212b37 on master.

@bentsku bentsku mentioned this pull request Feb 24, 2023
4 tasks
@bentsku bentsku self-assigned this Feb 24, 2023
@bentsku bentsku added the aws:apigateway Amazon API Gateway label Feb 24, 2023
@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from 47c5f27 to 48f01c1 Compare February 25, 2023 10:01
@bentsku bentsku changed the title wip: apigw parity work for resource proxy path apigw parity work for resource proxy path Feb 25, 2023
@bentsku bentsku marked this pull request as ready for review February 25, 2023 13:57
@bentsku bentsku requested a review from calvernaz as a code owner February 25, 2023 13:57
@bentsku bentsku changed the title apigw parity work for resource proxy path improve apigw parity work for Resource proxy path Feb 25, 2023
Copy link
Contributor

@calvernaz calvernaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bentsku bentsku force-pushed the apigw-parity-work-2 branch from 835ca2a to 36b13dc Compare February 27, 2023 13:53
@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from 48f01c1 to b738462 Compare February 27, 2023 14:32
Base automatically changed from apigw-parity-work-2 to master February 28, 2023 14:28
@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from a884dcd to 2c801d5 Compare February 28, 2023 14:39
@bentsku bentsku temporarily deployed to localstack-ext-tests February 28, 2023 14:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 30m 26s ⏱️ + 1m 19s
1 771 tests +3  1 397 ✔️ +3  374 💤 ±0  0 ±0 
2 491 runs  +3  1 773 ✔️ +3  718 💤 ±0  0 ±0 

Results for commit 900b216. ± Comparison against base commit 0212b37.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from 2c801d5 to 900b216 Compare March 1, 2023 09:39
@bentsku bentsku temporarily deployed to localstack-ext-tests March 1, 2023 09:39 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests March 1, 2023 14:19 — with GitHub Actions Inactive
@bentsku bentsku merged commit b81ef49 into master Mar 2, 2023
@bentsku bentsku deleted the apigw-parity-work-res-proxy branch March 2, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:apigateway Amazon API Gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants