Skip to content

apigw parity work resource method #7749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

apigw parity work resource method #7749

merged 2 commits into from
Mar 13, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 24, 2023 •
edited
Loading

This PR reimplements the Method resource CRUD API, removing the patches from moto to integrate them in our provider.
There was quite some validations on the json patch area, I will focus my time on resources where Update* is more often called, as those can be huge rabbit holes.

@bentsku bentsku self-assigned this Feb 24, 2023
@bentsku bentsku added the aws:apigateway Amazon API Gateway label Feb 24, 2023
@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch from 47c5f27 to 48f01c1 Compare February 25, 2023 10:01
@bentsku bentsku force-pushed the apigw-parity-work-res-methods branch from a32104e to 0b6bf50 Compare February 25, 2023 13:29
@coveralls
Copy link

coveralls commented Feb 25, 2023 •
edited
Loading

Coverage Status

Coverage: 85.203% (+0.1%) from 85.056% when pulling d0f78f4 on apigw-parity-work-res-methods into 4914f48 on master.

@bentsku bentsku force-pushed the apigw-parity-work-res-proxy branch 3 times, most recently from 2c801d5 to 900b216 Compare March 1, 2023 09:39
Base automatically changed from apigw-parity-work-res-proxy to master March 2, 2023 12:48
@bentsku bentsku force-pushed the apigw-parity-work-res-methods branch from 0b6bf50 to a279d83 Compare March 2, 2023 14:23
@bentsku bentsku temporarily deployed to localstack-ext-tests March 2, 2023 14:23 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 2, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 38m 39s ⏱️ + 6m 4s
1 793 tests +5  1 410 ✔️ +5  383 💤 ±0  0 ❌ ±0 
2 519 runs  +5  1 784 ✔️ +5  735 💤 ±0  0 ❌ ±0 

Results for commit d0f78f4. ± Comparison against base commit 4914f48.

♻️ This comment has been updated with latest results.

@bentsku bentsku temporarily deployed to localstack-ext-tests March 2, 2023 14:39 — with GitHub Actions Inactive
@bentsku bentsku changed the base branch from master to apigw-refactor-store March 2, 2023 14:48
@bentsku bentsku force-pushed the apigw-refactor-store branch from 80e8476 to d1da5a4 Compare March 4, 2023 13:19
@bentsku bentsku force-pushed the apigw-parity-work-res-methods branch from f5cb57c to 642d51e Compare March 4, 2023 13:20
Base automatically changed from apigw-refactor-store to master March 9, 2023 16:13
@bentsku bentsku force-pushed the apigw-parity-work-res-methods branch from 642d51e to 456136b Compare March 9, 2023 17:11
@bentsku bentsku temporarily deployed to localstack-ext-tests March 9, 2023 17:11 — with GitHub Actions Inactive
@bentsku bentsku force-pushed the apigw-parity-work-res-methods branch from 456136b to d0f78f4 Compare March 10, 2023 09:09
@bentsku bentsku temporarily deployed to localstack-ext-tests March 10, 2023 09:09 — with GitHub Actions Inactive
@bentsku bentsku marked this pull request as ready for review March 10, 2023 10:02
@bentsku bentsku requested a review from calvernaz as a code owner March 10, 2023 10:02
@bentsku bentsku changed the title wip: apigw parity work resource method apigw parity work resource method Mar 10, 2023
@bentsku bentsku mentioned this pull request Mar 10, 2023
Merged
calvernaz
calvernaz approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@calvernaz calvernaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

localstack/services/apigateway/patches.py
@@ -36,44 +36,6 @@ def apigateway_models_Stage_init(
apigateway_models_Stage_init_orig = apigateway_models.Stage.__init__
apigateway_models.Stage.__init__ = apigateway_models_Stage_init

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bentsku bentsku merged commit b5be94a into master Mar 13, 2023
@bentsku bentsku deleted the apigw-parity-work-res-methods branch March 13, 2023 12:04
@bentsku bentsku mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@calvernaz calvernaz calvernaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bentsku bentsku

Labels
aws:apigateway Amazon API Gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @coveralls @calvernaz