Skip to content

Enhance parity for API Gateway DynamoDB integrations #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2023
Merged

Enhance parity for API Gateway DynamoDB integrations #7753

merged 3 commits into from
Feb 25, 2023

Conversation

whummer
Copy link
Member

@whummer whummer commented Feb 25, 2023 •
edited
Loading

Enhance parity for API Gateway DynamoDB integrations. Follow-up from #7572

The PR also contains a few refactorings, starting to pull more of the service-specific integrations as classes into integrations.py

Summary of changes:

  • pull out logic for Kinesis/DDB integrations into separate KinesisIntegration and DynamoDBIntegration
  • add snapshot test for DDB integration
  • introduce a couple more @patch decorators for API GW patches
  • add BadRequestException for incorrect use of AWS_PROXY integration (AWS parity)
  • extract generic create_rest_api_with_integration fixture that can used for DDB&Kinesis integration tests (and other integrations in the future)

@whummer whummer temporarily deployed to localstack-ext-tests February 25, 2023 18:19 — with GitHub Actions Inactive
@whummer whummer requested a review from bentsku February 25, 2023 18:19
@whummer whummer changed the title Enhance parity for API Gateway DynamoDB integrations [wip] Enhance parity for API Gateway DynamoDB integrations Feb 25, 2023
calvernaz
calvernaz approved these changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@calvernaz calvernaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, LGTM! 🚀

@github-actions
Copy link

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   1h 2m 38s ⏱️ - 43m 47s
1 740 tests  -   15  1 354 ✔️  -   30  381 💤 +  10  5 ❌ +5 
1 740 runs   - 733  1 354 ✔️  - 406  381 💤  - 332  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 9eca2a5. ± Comparison against base commit 2e97ea1.

@whummer whummer temporarily deployed to localstack-ext-tests February 25, 2023 20:42 — with GitHub Actions Inactive
@whummer whummer changed the title [wip] Enhance parity for API Gateway DynamoDB integrations Enhance parity for API Gateway DynamoDB integrations Feb 25, 2023
@whummer whummer temporarily deployed to localstack-ext-tests February 25, 2023 21:25 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage: 85.081% (+0.05%) from 85.03% when pulling 3ba1e89 on apigw-integr-ddb into 2e97ea1 on master.

@whummer whummer merged commit 86494fb into master Feb 25, 2023
@whummer whummer deleted the apigw-integr-ddb branch February 25, 2023 22:11
@whummer whummer mentioned this pull request Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@bentsku bentsku Awaiting requested review from bentsku

1 more reviewer

@calvernaz calvernaz calvernaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whummer @coveralls @calvernaz