Skip to content

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Feb 28, 2023

Greenify pipeline: Fixes a suddenly failing test case for the new lambda provider tests.integration.awslambda.test_lambda_common.TestLambdaRuntimesCommon.test_introspection_invoke[nodejs18.x]
https://app.circleci.com/pipelines/github/localstack/localstack/12943/workflows/a0a0ec66-a580-472f-8ae7-66a573f3a2d6/jobs/93952

Quickfix skips snapshot validation for the environment variable NODE_EXTRA_CA_CERTS (only occurs for nodjs18 runtime)

Follow up

  • Check whether we need to set NODE_EXTRA_CA_CERTS explicitly to ensure runtime parity for the Nodejs18 runtime.

@joe4dev joe4dev temporarily deployed to localstack-ext-tests February 28, 2023 17:15 — with GitHub Actions Inactive
@joe4dev joe4dev requested a review from alexrashed February 28, 2023 17:18
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 32m 37s ⏱️ +49s
1 765 tests ±0  1 394 ✔️ ±0  371 💤 ±0  0 ±0 
2 485 runs  ±0  1 770 ✔️ ±0  715 💤 ±0  0 ±0 

Results for commit 54125fb. ± Comparison against base commit a3c03c5.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling this 👍

@joe4dev joe4dev merged commit 7c18795 into master Mar 1, 2023
@joe4dev joe4dev deleted the fix-lambda-nodejs18-cert-env-test-failure branch March 1, 2023 07:36
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for jumping on this! 🚀 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants