Skip to content

Conversation

calvernaz
Copy link
Contributor

@calvernaz calvernaz commented Mar 2, 2023

Summary

Minor fix to handle template expressions for WebSockets API for the simplest case, non VTL expressions.

https://docs.aws.amazon.com/apigateway/latest/developerguide/websocket-api-data-transformations.html#apigateway-websocket-api-template-selection-expressions

Issues

Handles #7737

@calvernaz calvernaz temporarily deployed to localstack-ext-tests March 2, 2023 00:29 — with GitHub Actions Inactive
@calvernaz calvernaz marked this pull request as draft March 2, 2023 00:29
@calvernaz calvernaz changed the title wip websocket template expression Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

LocalStack integration with Pro

1 827 tests   1 351 ✔️  1h 18m 8s ⏱️
       1 suites     400 💤
       1 files         76

For more details on these failures, see this check.

Results for commit 73743aa.

♻️ This comment has been updated with latest results.

@calvernaz calvernaz changed the title websocket template expression Fix websocket template expression Mar 22, 2023
@calvernaz calvernaz force-pushed the fix-apigw-ws-kinesis branch from 2eea7e5 to 73743aa Compare March 22, 2023 15:04
@calvernaz calvernaz temporarily deployed to localstack-ext-tests March 22, 2023 15:04 — with GitHub Actions Inactive
@calvernaz calvernaz force-pushed the fix-apigw-ws-kinesis branch from 9063f6f to 6c382e4 Compare March 25, 2023 07:45
@coveralls
Copy link

Coverage Status

Coverage: 81.738% (-0.009%) from 81.746% when pulling e69e2ad on fix-apigw-ws-kinesis into 7ae6048 on master.

@calvernaz calvernaz marked this pull request as ready for review March 25, 2023 09:30
@calvernaz calvernaz merged commit e8d3914 into master Mar 25, 2023
@calvernaz calvernaz deleted the fix-apigw-ws-kinesis branch March 25, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants