add an exception handler to serialize werkzeug HTTPException #7790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to our fallback exception handler to render werkzeug HTTPException instances.
Previously, calling internal resources (or custom routes that would not be detected as s3 routes) with wrong methods would output:
because it interprets the
MethodNotAllowed
exception as unexpected exception. with this new logic that generalize capturing of werkzeug HTTP exceptions, you can actually raise HTTP exceptions from within handlers, and get proper exception messages:Unfortunately, because the service name parser is still executed before the router handler, it doesn't work for most requests, since those are captured by the
ServiceExceptionSerializer
which will serialize exceptions into s3 exceptions although the calls are not being made to s3. I added a bunch of tests & xfailed tests to document the expected behavior once that is remedied.