Skip to content

add cwd parameter to ShellCommandThread #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

add cwd parameter to ShellCommandThread #7800

merged 1 commit into from
Mar 5, 2023

Conversation

thrau
Copy link
Member

@thrau thrau commented Mar 3, 2023

This PR passes the cwd argument through the ShellCommandThread to the underlying popen command.

@thrau thrau temporarily deployed to localstack-ext-tests March 3, 2023 22:53 — with GitHub Actions Inactive
@thrau thrau requested a review from whummer March 3, 2023 23:33
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

LocalStack integration with Pro

       3 files  +    1         3 suites  +1   1h 35m 3s ⏱️ +50s
1 778 tests ±    0  1 399 ✔️ +    3  379 💤  -     3  0 ❌ ±0 
2 504 runs  +371  1 775 ✔️ +203  729 💤 +168  0 ❌ ±0 

Results for commit e057f85. ± Comparison against base commit 712c40b.

whummer
whummer approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @thrau ! 👍

@thrau thrau merged commit 881018e into master Mar 5, 2023
@thrau thrau deleted the fix-shell-command-thread branch March 5, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thrau @whummer