Skip to content

Conversation

giograno
Copy link
Member

@giograno giograno commented Mar 9, 2023

Adding the persistence plugin hooks to the StepFunctions provider.

@giograno giograno requested a review from thrau March 9, 2023 21:02
@giograno giograno temporarily deployed to localstack-ext-tests March 9, 2023 21:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 30m 57s ⏱️ - 12m 40s
1 787 tests ±0  1 404 ✔️ ±0  383 💤 ±0  0 ±0 
2 513 runs  ±0  1 778 ✔️ ±0  735 💤 ±0  0 ±0 

Results for commit 8ec965d. ± Comparison against base commit e7836bf.

@giograno giograno added the aws:stepfunctions AWS Step Functions label Mar 13, 2023
@giograno giograno self-assigned this Mar 13, 2023
@giograno giograno marked this pull request as ready for review March 13, 2023 21:04
@coveralls
Copy link

Coverage Status

Coverage: 85.115% (-0.02%) from 85.134% when pulling 8ec965d on persistence-stepfunctions into e7836bf on master.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! maybe we could, in a next step, introduce an encapsulation like we did for kinesis https://github.com/localstack/localstack/pull/7825/files

@giograno
Copy link
Member Author

LGTM! maybe we could, in a next step, introduce an encapsulation like we did for kinesis https://github.com/localstack/localstack/pull/7825/files

100%! Avoided it for this PR since I have high hopes for the new provider :)

@giograno giograno merged commit fd25513 into master Mar 14, 2023
@giograno giograno deleted the persistence-stepfunctions branch March 14, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:stepfunctions AWS Step Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants