Skip to content

Allow privileged mode to be passed as additional flag #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

Allow privileged mode to be passed as additional flag #7835

merged 2 commits into from
Mar 14, 2023

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Mar 10, 2023 •
edited
Loading

Allows the --privileged flag to be passed in additional_flags when running Docker containers.

@viren-nadkarni viren-nadkarni temporarily deployed to localstack-ext-tests March 10, 2023 09:52 — with GitHub Actions Inactive
@viren-nadkarni viren-nadkarni self-assigned this Mar 10, 2023
@github-actions
Copy link

github-actions bot commented Mar 10, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 31m 38s ⏱️ -57s
1 788 tests ±0  1 406 ✔️ +1  382 💤  - 1  0 ❌ ±0 
2 514 runs  ±0  1 780 ✔️ +1  734 💤  - 1  0 ❌ ±0 

Results for commit 3ace789. ± Comparison against base commit 4914f48.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni temporarily deployed to localstack-ext-tests March 10, 2023 11:31 — with GitHub Actions Inactive
@viren-nadkarni viren-nadkarni force-pushed the docker-privileged-additional-flags branch from 27d28a7 to 3ace789 Compare March 10, 2023 11:32
@viren-nadkarni viren-nadkarni temporarily deployed to localstack-ext-tests March 10, 2023 11:33 — with GitHub Actions Inactive
@viren-nadkarni viren-nadkarni marked this pull request as ready for review March 10, 2023 11:33
@coveralls
Copy link

Coverage Status

Coverage: 85.06% (+0.004%) from 85.056% when pulling 3ace789 on docker-privileged-additional-flags into 4914f48 on master.

@viren-nadkarni viren-nadkarni requested a review from thrau March 14, 2023 05:27
thrau
thrau approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but i'll let one of the codeowners sign off :-)

dfangl
dfangl approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will just ping @joe4dev here, as I think he is reworking this method. Feel free to merge though.

@viren-nadkarni viren-nadkarni merged commit d47f509 into master Mar 14, 2023
@viren-nadkarni viren-nadkarni deleted the docker-privileged-additional-flags branch March 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@viren-nadkarni viren-nadkarni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viren-nadkarni @coveralls @thrau @dfangl