Skip to content

Remove extra slash in SQS path strategy #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2023
Merged

Remove extra slash in SQS path strategy #7837

merged 2 commits into from
Mar 11, 2023

Conversation

baermat
Copy link
Member

@baermat baermat commented Mar 10, 2023

This PR removes a duplicate slash when creating the queue url under the path endpoint strategy

@baermat baermat temporarily deployed to localstack-ext-tests March 10, 2023 14:49 — with GitHub Actions Inactive
@baermat baermat temporarily deployed to localstack-ext-tests March 10, 2023 15:06 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage: 85.072% (+0.002%) from 85.07% when pulling 7185a6f on sqs-fix-extra-slash into e9c2ce5 on master.

@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 31m 24s ⏱️ - 1m 16s
1 789 tests +1  1 407 ✔️ +1  382 💤 ±0  0 ❌ ±0 
2 515 runs  +1  1 781 ✔️ +1  734 💤 ±0  0 ❌ ±0 

Results for commit 7185a6f. ± Comparison against base commit e9c2ce5.

@baermat baermat marked this pull request as ready for review March 10, 2023 16:43
@baermat baermat requested a review from thrau as a code owner March 10, 2023 16:43
thrau
thrau approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice catch

@thrau thrau merged commit b584f04 into master Mar 11, 2023
@alexrashed alexrashed deleted the sqs-fix-extra-slash branch March 27, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baermat @coveralls @thrau