Skip to content

Fix transformation of falsy values in KeyValueBasedTransformer #7852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2023
Merged

Fix transformation of falsy values in KeyValueBasedTransformer #7852

merged 3 commits into from
Mar 13, 2023

Conversation

dominikschubert
Copy link
Member

Encountered this issue when I was trying to replace a number that flaked between 0 and non-0

Changes

  • Explicitly check for None with matched result

@dominikschubert dominikschubert self-assigned this Mar 13, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 13, 2023 17:25 — with GitHub Actions Inactive
steffyP
steffyP approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Let's hope it doesn't break existing tests 🤞 😅

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 42m 48s ⏱️ + 4m 49s
1 797 tests ±0  1 415 ✔️ ±0  382 💤 ±0  0 ❌ ±0 
2 523 runs  ±0  1 789 ✔️ ±0  734 💤 ±0  0 ❌ ±0 

Results for commit 5bd5750. ± Comparison against base commit aa0b200.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert requested a review from dfangl as a code owner March 13, 2023 19:35
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 13, 2023 19:35 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage: 85.165% (-0.01%) from 85.176% when pulling 5bd5750 on fix_snapshot-keyvalue-transformer into aa0b200 on master.

@dominikschubert dominikschubert merged commit 9165763 into master Mar 13, 2023
@dominikschubert dominikschubert deleted the fix_snapshot-keyvalue-transformer branch March 13, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@dominikschubert dominikschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @steffyP