Skip to content

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Mar 16, 2023

These variables are

  • LOCALSTACK_HOSTNAME which is not meant to be settable by the user as it's used internally, but it is settable
  • LOCALSTACK_HOST which is a new variable that we plan to use in exchange for HOSTNAME_EXTERNAL and LOCALSTACK_HOSTNAME.

These variables are added so that we can use the analytics to see the usage of the previous variables drop.

These variables are
* `LOCALSTACK_HOSTNAME` which is not _meant_ to be settable by the user
  as it's used internally, but it is settable
* `LOCALSTACK_HOST` which is a new variable that we plan to use in
  exchange for `HOSTNAME_EXTERNAL` and `LOCALSTACK_HOSTNAME`.

These variables are added so that we can use the analytics to see the
usage of the previous variables drop.
@simonrw simonrw self-assigned this Mar 16, 2023
@simonrw simonrw temporarily deployed to localstack-ext-tests March 16, 2023 06:56 — with GitHub Actions Inactive
@simonrw simonrw requested a review from ackdav March 16, 2023 07:00
@coveralls
Copy link

Coverage Status

Coverage: 85.098% (-0.006%) from 85.105% when pulling e55c445 on track-hostname-envars into 31c2825 on master.

@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 41m 44s ⏱️ +40s
1 802 tests ±0  1 420 ✔️ +1  382 💤  - 1  0 ±0 
2 528 runs  ±0  1 794 ✔️ +1  734 💤  - 1  0 ±0 

Results for commit e55c445. ± Comparison against base commit 31c2825.

Copy link
Member

@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for adding this before v2

@simonrw simonrw marked this pull request as ready for review March 16, 2023 09:57
@simonrw simonrw merged commit d010e52 into master Mar 16, 2023
@simonrw simonrw deleted the track-hostname-envars branch March 16, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants