Skip to content

Conversation

thrau
Copy link
Member

@thrau thrau commented Mar 16, 2023

This PR removes the immediate use of the LEGACY_EDGE_PROXY config flag. Dead code removal can happen at a later point.

@thrau thrau requested a review from alexrashed March 16, 2023 17:15
@thrau thrau temporarily deployed to localstack-ext-tests March 16, 2023 17:15 — with GitHub Actions Inactive
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good to see the legacy edge proxy handling being removed! 💯 🚀

Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning up 🧹

@github-actions
Copy link

LocalStack integration with Pro

       3 files  +    1         3 suites  +1   1h 42m 54s ⏱️ + 9m 56s
1 795 tests  -     1  1 415 ✔️ +    2  380 💤  -     3  0 ±0 
2 513 runs  +366  1 781 ✔️ +197  732 💤 +169  0 ±0 

Results for commit 54111be. ± Comparison against base commit ce99286.

@thrau thrau merged commit 10f7a4b into v2 Mar 16, 2023
@thrau thrau deleted the v2-remove-legacy-edge-proxy branch March 16, 2023 22:18
thrau added a commit that referenced this pull request Mar 17, 2023
thrau added a commit that referenced this pull request Mar 18, 2023
thrau added a commit that referenced this pull request Mar 21, 2023
thrau added a commit that referenced this pull request Mar 22, 2023
dfangl pushed a commit that referenced this pull request Mar 22, 2023
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants