Skip to content

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Mar 22, 2023

We will start localstack with community services enabled if the localstack/localstack image is used instead of localstack/localstack-pro. Also, we have a new version-tag file for the new bigdata tag. This PR adapts the existing warning to consider these changes.

@silv-io silv-io requested a review from alexrashed March 22, 2023 13:50
@silv-io silv-io temporarily deployed to localstack-ext-tests March 22, 2023 13:50 — with GitHub Actions Inactive
@silv-io silv-io temporarily deployed to localstack-ext-tests March 22, 2023 14:05 — with GitHub Actions Inactive
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we should change the link though (see comment)?

@silv-io silv-io temporarily deployed to localstack-ext-tests March 22, 2023 15:43 — with GitHub Actions Inactive
@silv-io silv-io merged commit acf300c into v2 Mar 22, 2023
@silv-io silv-io deleted the update-pro-image-warning branch March 22, 2023 15:52
@coveralls
Copy link

Coverage Status

Coverage: 85.009% (-0.004%) from 85.013% when pulling bd7c6f0 on update-pro-image-warning into 6e81652 on v2.

dfangl pushed a commit that referenced this pull request Mar 22, 2023
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants