Skip to content

skip test_kinesis_firehose_opensearch_s3_backup + es equivalent + fix s3 flake #7962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2023
Merged

skip test_kinesis_firehose_opensearch_s3_backup + es equivalent + fix s3 flake #7962

merged 3 commits into from
Mar 24, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 24, 2023 •
edited
Loading

Firehose tests with OpenSearch/ES have been really flaky and we're trying to get a deployment out. Let's see if this goes further

Trying to fix flakiness of the s3 CORS tests that make extensive use of virtual host addressing... could be some issue there?

@bentsku bentsku changed the title try skipping test_kinesis_firehose_opensearch_s3_backup[domain] skip test_kinesis_firehose_opensearch_s3_backup + es equivalent + fix s3 flake Mar 24, 2023
@bentsku bentsku requested a review from thrau March 24, 2023 19:39
thrau
thrau approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Need to get the pipeline 💚

@thrau thrau merged commit 7ae6048 into master Mar 24, 2023
@thrau thrau deleted the skip-flaky-test branch March 24, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @thrau