Skip to content

add test for ListMultipartUploads #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

add test for ListMultipartUploads #7981

merged 1 commit into from
Mar 28, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 27, 2023

While checking https://docs.localstack.cloud/references/coverage/coverage_s3, it appeared ListMultipartUploads was not implemented. It seems it is, and I've added a test for coverage of that operation.

\cc @steffyP @joe4dev

@bentsku bentsku requested review from macnev2013 and steffyP March 27, 2023 17:53
@steffyP
Copy link
Member

steffyP commented Mar 28, 2023

thanks for the hint @bentsku, will take a look on why it is classified as "not implemented".

steffyP
steffyP approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding even more snapshot tests 🥳 🚀 🙏 📸 ❤️
test LGTM!

@steffyP steffyP mentioned this pull request Mar 28, 2023
Merged
@bentsku bentsku self-assigned this Mar 28, 2023
@bentsku bentsku added the aws:s3 Amazon Simple Storage Service label Mar 28, 2023
@bentsku bentsku mentioned this pull request Mar 28, 2023
Merged
@bentsku bentsku merged commit 649e77a into master Mar 28, 2023
@bentsku bentsku deleted the s3-check-multipart branch March 28, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @steffyP