Skip to content

Conversation

pguillory
Copy link

The response to a CreateMultipartUpload request should contain a root element InitiateMultipartUploadResult. This will align with the AWS API docs and with client libraries that check the root element.

#8030

The response to a CreateMultipartUpload request should contain a root element
InitiateMultipartUploadResult. This will align with the AWS API docs and with
client libraries that check the root element.
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Mar 31, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pguillory
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@bentsku
Copy link
Contributor

bentsku commented Apr 1, 2023

Hi @pguillory and thanks for your contribution!

However, the code you are updating is auto-generated and updated every week, based on the botocore specs.
We need to modify this data in another way, through patches.

Here are some examples on how we've already updated some responses: #8021, #7983 and #7545.
You'd also need to regenerate the API with the following command inside LocalStack virtual environment: python -m localstack.aws.scaffold generate --save s3.

I can also take a stab a it tomorrow if you'd like, as it is a bit tedious and also quite urgent. I'm currently planning to try to collect all XML responses from every operation to compare them to the specs and correct all of the remaining ones we are missing.
It seems CompleteMultipartUploadResult will also be wrong compared to CompleteMultipartUploadOutput from the specs.

@bentsku
Copy link
Contributor

bentsku commented Apr 1, 2023

There's now a PR which would fix all S3 operations root tag at #8037.

@pguillory
Copy link
Author

Great, closing in favor of #8037. Thanks for your help @bentsku and everyone maintaining LocalStack! It's been very helpful in enabling us to write high quality unit tests for systems that touch S3, of which we have a lot.

@pguillory pguillory closed this Apr 1, 2023
@pguillory pguillory deleted the InitiateMultipartUploadResult branch April 1, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants