Skip to content

enforce semver labels, block major labeled PRs #8095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 3, 2023
Merged

enforce semver labels, block major labeled PRs #8095

merged 6 commits into from
May 3, 2023

Conversation

alexrashed
Copy link
Member

This PR contains the following changes:

  • It renames some of the existing GitHub workflow files (in order to somewhat categorize them).
  • It adds two more workflows:
    • .github/workflows/pr-enforce-pr-labels.yml
      • This workflow enforces that every single PR has to be labeled with exactly one of the following three labels: semver: major, semver: minor, semver: patch.
    • .github/workflows/pr-enforce-bugfix-master.yml
      • This workflow enforces that (just like now) only PRs which contain patches (non-breaking, no new features) can be merged.
      • This means that when this workflow is enabled, PRs which have been labeled either with semver: minor or semver: major are rejected.
      • If we decide that we open the master branch for features, we can disable this workflow (or rewrite it such that we block PRs labeled with semver: major).

@alexrashed alexrashed requested a review from thrau April 7, 2023 10:16
@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 7, 2023
@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited
Loading

Coverage Status

Coverage: 82.108% (+0.01%) from 82.096% when pulling 6c8fd47 on enforce-semver-labels into 8c9f822 on master.

@alexrashed alexrashed added semver: major Breaking changes which can be included in a major release only semver: patch Non-breaking changes which can be included in patch releases area: ci Running LocalStack in CI environments and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases semver: patch Non-breaking changes which can be included in patch releases semver: major Breaking changes which can be included in a major release only labels Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

LocalStack integration with Pro

1 894 tests  ±0   1 697 ✔️ ±0   1h 23m 34s ⏱️ -39s
       1 suites ±0      197 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit e04be05. ± Comparison against base commit 447a64a.

@alexrashed alexrashed marked this pull request as draft April 7, 2023 11:55
@alexrashed alexrashed force-pushed the enforce-semver-labels branch from e04be05 to 3988442 Compare April 25, 2023 09:58
@alexrashed alexrashed added semver: major Breaking changes which can be included in a major release only semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases semver: major Breaking changes which can be included in a major release only semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Apr 25, 2023
@localstack localstack deleted a comment from localstack-bot Apr 25, 2023
@alexrashed alexrashed added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: major Breaking changes which can be included in a major release only labels Apr 25, 2023
@alexrashed alexrashed marked this pull request as ready for review April 25, 2023 10:08
@alexrashed
Copy link
Member Author

FYI: The "enforce bugfix on master" has been changed to "enforce no major on master". This action will stay active until the next major release (to avoid unwanted breaking changes being merged into the master).
I am still looking for any feedback! Please let me know if you feel this is not necessary, useless, should be changed, is nice,...

@alexrashed alexrashed changed the title enforce semver labels, block minor and major labeled PRs enforce semver labels, block major labeled PRs Apr 25, 2023
@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited
Loading

LocalStack Community integration with Pro

1 990 tests   1 726 ✔️  1h 17m 27s ⏱️
       2 suites     264 💤
       2 files           0 ❌

Results for commit 6c8fd47.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the enforce-semver-labels branch from 3c794f1 to 48d2657 Compare April 27, 2023 07:00
@alexrashed alexrashed added semver: major Breaking changes which can be included in a major release only and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Apr 27, 2023
@alexrashed alexrashed added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: major Breaking changes which can be included in a major release only labels Apr 27, 2023
thrau
thrau approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM! as i've mentioned, i think part of this PR should also be an (initial/tentative) definition of major/minor/patch, that we should IMO also document in the PR and our contribution guidelines.

@alexrashed alexrashed force-pushed the enforce-semver-labels branch from 48d2657 to 6c8fd47 Compare May 3, 2023 07:26
@alexrashed alexrashed merged commit ec6fd4b into master May 3, 2023
@alexrashed alexrashed deleted the enforce-semver-labels branch May 3, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
area: ci Running LocalStack in CI environments semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @thrau