Skip to content

Always return bridge as fallback network #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Always return bridge as fallback network #8151

merged 1 commit into from
Apr 18, 2023

Conversation

dominikschubert
Copy link
Member

In some cases the returned network was actually None here, which wasn't really handled anywhere downstream and was also in conflict with the method description. Returning and trying to use the bridge network here instead should still be a more sensible default.

Changes

  • get_main_container_network now also returns "bridge" when DOCKER_CLIENT.get_networks fails

@dominikschubert dominikschubert requested a review from dfangl April 17, 2023 09:53
@dominikschubert dominikschubert self-assigned this Apr 17, 2023
@dominikschubert dominikschubert requested a review from joe4dev April 17, 2023 10:00
@coveralls
Copy link

Coverage Status

Coverage: 82.017% (+0.006%) from 82.011% when pulling f1643f1 on fix_network-fallback into 4d0a016 on master.

dfangl
dfangl approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks!

@github-actions
Copy link

LocalStack Community integration with Pro

1 901 tests   1 698 ✔️  1h 11m 55s ⏱️
       2 suites     203 💤
       2 files           0 ❌

Results for commit f1643f1.

@dominikschubert dominikschubert merged commit e2561dc into master Apr 18, 2023
@dominikschubert dominikschubert deleted the fix_network-fallback branch April 18, 2023 16:47
@dominikschubert dominikschubert added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

Assignees

@dominikschubert dominikschubert

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @dfangl