Skip to content

Conversation

whummer
Copy link
Member

@whummer whummer commented Apr 18, 2023

Enhance parity for ACM certificates issued for wildcard subdomains . Addresses #8156

With the changes in this PR, the following TF script deploys successfully (confirmed that it was hanging indefinitely before):

resource "aws_route53_zone" "this" {
  name = "example.com"
}

module "acm" {
  source  = "terraform-aws-modules/acm/aws"
  version = "4.3.2"

  domain_name         = "*.example.com"
  wait_for_validation = true
  zone_id             = aws_route53_zone.this.zone_id
}

data "aws_acm_certificate" "this" {
  depends_on = [module.acm]

  domain = "*.example.com"
}

The changes are covered by a snapshot test. Overall, the amount of patching we're performing in ACM is becoming a bit ridiculous ;) - probably a candidate for decoupling from moto in the near future as well.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

LocalStack Community integration with Pro

1 912 tests   1 707 ✔️  1h 11m 45s ⏱️
       2 suites     205 💤
       2 files           0

Results for commit df68d14.

♻️ This comment has been updated with latest results.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another service with snapshot tests being introduced, that's awesome!
I only have some smaller nitpicks or somewhat fundamental questions (which aren't to be solved / answered within the scope of this PR), besides that it looks great! 🚀

@whummer whummer merged commit 11c094b into master Apr 19, 2023
@whummer whummer deleted the acm-wildcard-domain branch April 19, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants