Skip to content

fix: s3 parsing key with trailing backslash and reserved chars #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

fix: s3 parsing key with trailing backslash and reserved chars #8198

merged 2 commits into from
Apr 26, 2023

Conversation

giograno
Copy link
Member

Addresses #8174.

In a nutshell, the issue was caused by not re-adding a trailing backslash for keys with special quoted characters.

@giograno giograno added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Apr 26, 2023
@giograno giograno requested a review from steffyP April 26, 2023 00:27
@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

LocalStack Community integration with Pro

1 952 tests   1 717 ✔️  1h 16m 22s ⏱️
       2 suites     235 💤
       2 files           0 ❌

Results for commit dccca3a.

♻️ This comment has been updated with latest results.

@steffyP steffyP requested a review from bentsku April 26, 2023 07:34
@giograno giograno force-pushed the s3-backslash-special branch from 7583e52 to dccca3a Compare April 26, 2023 13:12
@coveralls
Copy link

Coverage Status

Coverage: 82.139% (+0.002%) from 82.137% when pulling dccca3a on s3-backslash-special into 25f4707 on master.

@giograno giograno marked this pull request as ready for review April 26, 2023 15:37
steffyP
steffyP approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping onto this issue, @giograno! The changes LGTM 👍
I also added @bentsku as reviewer as he is the serviceowner 🙂

bentsku
bentsku approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of this! 👍 and providing a clean fix!

@giograno giograno merged commit 35461dd into master Apr 26, 2023
@giograno giograno deleted the s3-backslash-special branch April 26, 2023 19:12
@alexrashed alexrashed mentioned this pull request May 4, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

@bentsku bentsku bentsku approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed

@thrau thrau Awaiting requested review from thrau

Assignees
No one assigned
Labels
aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giograno @coveralls @steffyP @bentsku