add s3 CopyObject tests #8216
Merged
add s3 CopyObject tests #8216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90c204d to
a4d6a08
Compare
4ad947d to
cf879c2
Compare
05b48c5 to
7823324
Compare
1 task
7823324 to
ae72000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: this is WIP PR, all these tests will/should fail as the functionality is not yet implemented in moto. Will depend on upstream changes, the PR is available here: getmoto/moto#6264This PR builds on #8326
This will validate the fixes for #8172
All the tests will pass once all these PR are merged and a new release of moto-ext is done. (tested locally).
Sorry for the big amount of tests added in only one PR, this was built incrementally and I did not want to multiply the drafts PR. All those tests are AWS validated and snapshotted, so we can be pretty confident it works fine.
Moto PRs linked:
The next step building on these tests is to remove the functionality in our provider that has been added in moto now: calculating checksums and saving them to keys. Moto does not support CRC32C yet, so we will have a special case for this checksum algorithm. This will be done in a following PR.