Skip to content

fix mapping of insufficient scopes return value to access denied exception #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2023
Merged

fix mapping of insufficient scopes return value to access denied exception #8251

merged 1 commit into from
May 4, 2023

Conversation

alexrashed
Copy link
Member

This PR relates to / extends #8215.

Motivation

We are currently seeing a new error message in the community test pipeline in -ext which indicate an error when verifying the access denied error of a docker push.

2023-05-04T08:32:39.397 DEBUG --- [  MainThread] localstack.utils.container_utils.docker_cmd_client : Pushing image with cmd: ['docker', 'push', 'alpine']
2023-05-04T08:32:39.397 DEBUG --- [  MainThread] localstack.utils.run       : Executing command: ['docker', 'push', 'alpine']
ERROR: '['docker', 'push', 'alpine']': exit code 1; output: b'Using default tag: latest\nThe push refers to repository [docker.io/library/alpine]\nf1417ff83b31: Preparing\nunauthorized: access token has insufficient scopes\n'
RERUN
../localstack/tests/integration/docker_utils/test_docker.py::TestDockerClient::test_push_access_denied[CmdDockerClient]

While it is not clear why there are different error messages returned here, we still have to map this return to AccessDenied (as it effectively is).

Changes

  • Add case of access token has insufficient scopes to be mapped to a AccessDenied exception

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label May 4, 2023
@coveralls
Copy link

Coverage Status

Coverage: 82.1% (-0.0006%) from 82.101% when pulling 9f9100a on fix-docker-access-denied into fd9a553 on master.

@github-actions
Copy link

github-actions bot commented May 4, 2023

LocalStack Community integration with Pro

1 997 tests   1 733 ✔️  1h 12m 54s ⏱️
       2 suites     264 💤
       2 files           0 ❌

Results for commit 9f9100a.

@alexrashed alexrashed merged commit c28ef9a into master May 4, 2023
@alexrashed alexrashed deleted the fix-docker-access-denied branch May 4, 2023 09:50
@dfangl dfangl mentioned this pull request May 4, 2023
Merged
3 tasks
@thrau thrau mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dfangl