Skip to content

fix SdkDockerClient recovery if docker socket not available initially #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2023
Merged

fix SdkDockerClient recovery if docker socket not available initially #8279

merged 2 commits into from
May 9, 2023

Conversation

alexrashed
Copy link
Member

Currently, if the Docker socket is not available at the start of LocalStack, the initialization of the SdkDockerClient fails and the client will not recover during the runtime of LocalStack.
This PR changes this behavior such that:

  • The initialization is tried again if the client is accessed at runtime, but not already available (lazy init of the SDK client if it was unsuccessful before).
  • Introduces a retry config DOCKER_SDK_DEFAULT_RETRIES which allows configuring the amount of retries when initializing the client.

This addresses localstack/helm-charts#21.

@alexrashed alexrashed mentioned this pull request May 8, 2023
Merged
8 tasks
@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023 •
edited
Loading

LocalStack Community integration with Pro

2 017 tests   1 737 ✔️  1h 17m 15s ⏱️
       2 suites     280 💤
       2 files           0 ❌

Results for commit 2067aa3.

♻️ This comment has been updated with latest results.

dfangl
dfangl reviewed May 8, 2023
View reviewed changes
@coveralls
Copy link

Coverage Status

Coverage: 82.192% (+0.03%) from 82.161% when pulling 2067aa3 on fix-docker-sdk-initialization into 42f62d3 on master.

@alexrashed alexrashed mentioned this pull request May 9, 2023
Closed
@alexrashed alexrashed requested a review from dfangl May 9, 2023 09:22
@alexrashed alexrashed merged commit 4549b2c into master May 9, 2023
@alexrashed alexrashed deleted the fix-docker-sdk-initialization branch May 9, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@thrau thrau Awaiting requested review from thrau

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dfangl