add test for S3 LegalHold when targeting object version #8291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cba82e1 to
3af808c
Compare
1 task
macnev2013
reviewed
May 22, 2023
| @@ -3887,6 +3887,89 @@ def test_s3_sse_default_kms_key( | |||
| response = aws_client.s3.get_object(Bucket=bucket_1, Key=key_name) | |||
| snapshot.match("get-obj-default-kms-s3-key-from-bucket", response) | |||
|
|
|||
| @pytest.mark.aws_validated | |||
| @pytest.mark.skip_snapshot_verify(paths=["$..ServerSideEncryption"]) | |||
There was a problem hiding this comment.
Why are we skipping to verify the path ServerSideEncryption ?
There was a problem hiding this comment.
Because AWS now has server side encryption by default on all newly created buckets: https://docs.aws.amazon.com/AmazonS3/latest/userguide/default-encryption-faq.html
This behaviour is not yet in moto or LocalStack, so we need to skip the return value for now. All newly created tests now have to have this skip until we fix it 😞
macnev2013
approved these changes
May 22, 2023
macnev2013
approved these changes
May 22, 2023
macnev2013
approved these changes
May 22, 2023
3af808c to
1ffab12
Compare
1ffab12 to
545b737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test to check the behaviour and the fix of getmoto/moto#6295
This PR builds on #8326
This will confirm the fix for #8183