Fix CFn model class & attribute lookup #8318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
May 15, 2023
There was a problem hiding this comment.
Kudos for greenifying the build @dominikschubert ! 🚀
I have only a small comment/question, but imho we could also address this in a follow-up if we want to get the changes out quickly. 👍
| kw["resources"][kw["resource_id"]]["PhysicalResourceId"] | ||
| ] | ||
| }, | ||
| "parameters": {"InstanceIds": ["InstanceId"]}, |
There was a problem hiding this comment.
nit: If I'm not mistaken, this would create a parameters dict like
{"InstanceIds": "<my-instance-id>"}
instead of
{"InstanceIds": ["<my-instance-id>"]}
Not very intuitive, but that's the current logic in template_deployer.py, if I'm reading it correctly: https://github.com/localstack/localstack/blob/master/localstack/services/cloudformation/engine/template_deployer.py#L920-L922
There was a problem hiding this comment.
Will fix in a follow-up soon 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in recent CFn refactorings.
PRO overwrites get_resource_type to add support for custom resources, but we didn't use this in get_ref and other call sites, causing this to fail -ext tests.