Skip to content

upgrade debian to bookworm #9288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2023
Merged

upgrade debian to bookworm #9288

merged 5 commits into from
Oct 17, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Oct 4, 2023 •
edited
Loading

Motivation

This PR upgrades the OS version of the Docker image from Debian Bullseye to Debian Bookworm.
The last upgrade was done with the release of version 2.1.0 in #8344 / #7876.
Since the Debian repositories for bookworm do not contain openjdk-11 anymore, I also switched the java-builder to use the eclipse-temurin:11 image.

Changes

  • The base image's OS has been upgraded from Debian Bullseye (oldstable) to Debian Bookworm (stable).
  • The java-builder stage has been replaced to use Eclipse Temurin image (because Debian Bookworm does not have OpenJDK in the repos anymore).
    • We are already using Eclipse Temurin in the Java installer if we need other Java versions (for BigData services).

Testing

  • Tested by building the image locally.
  • If all tests are green, we can be quite confident that everything works correctly.

Merge?

This PR contains some important changes:

  • Updates the base image from Debian Bullseye to Debian Bookworm.
    • This could have an implication for users which install any kind of packages in the Docker image.
  • Change the Java JDK from OpenJDK in the package repo to the Temurin build.
    • I think this should actually be a safe change.
    • Eclipse Temurin is based OpenJDK.

We should decide on when to merge this change. The last time (with the Debian upgrade from Buster to Bullseye), we didn't really see any issues among our user-base.

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 10m 55s ⏱️ - 8m 11s
2 254 tests ±0  1 753 ✔️ +2  501 💤 ±0  0 ❌  - 2 
2 255 runs  ±0  1 753 ✔️ +2  502 💤 ±0  0 ❌  - 2 

Results for commit f2a4985. ± Comparison against base commit 25d164e.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the upgrade-debian-to-bookworm branch from 6168959 to 43d76f6 Compare October 6, 2023 11:48
@alexrashed alexrashed requested a review from dfangl October 6, 2023 12:14
@alexrashed alexrashed self-assigned this Oct 6, 2023
@coveralls
Copy link

coveralls commented Oct 6, 2023 •
edited
Loading

Coverage Status

coverage: 82.937% (-0.04%) from 82.979% when pulling f2a4985 on upgrade-debian-to-bookworm into 25d164e on master.

dfangl
dfangl approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexrashed alexrashed force-pushed the upgrade-debian-to-bookworm branch from 43d76f6 to 90469b8 Compare October 16, 2023 12:46
@alexrashed alexrashed marked this pull request as ready for review October 17, 2023 08:21
@alexrashed alexrashed force-pushed the upgrade-debian-to-bookworm branch from 90469b8 to 5f44fcd Compare October 17, 2023 08:28
@alexrashed alexrashed force-pushed the upgrade-debian-to-bookworm branch from 5f44fcd to f2a4985 Compare October 17, 2023 08:30
@alexrashed alexrashed requested a review from thrau as a code owner October 17, 2023 08:30
@alexrashed alexrashed merged commit 0d7088d into master Oct 17, 2023
@alexrashed alexrashed deleted the upgrade-debian-to-bookworm branch October 17, 2023 09:58
@alexrashed alexrashed mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@alexrashed alexrashed

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dfangl