Remove botocore dependency by transform any IO-stream #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffyP
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Great initiative @bblommers 🙌 🚀
This makes a lot of sense, thanks for tackling!
| @@ -12,7 +12,6 @@ description = "Extracted snapshot testing lib for LocalStack" | |||
| dependencies = [ | |||
| "jsonpath-ng>1.6", | |||
| "deepdiff", | |||
| "botocore", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the footprint for any projects that use this library - they shouldn't have to have
botocoreas a dependency.Note that I went with the
io.IOBaseas a replacement, simply because that's the immediate parent ofbotocore.response.StreamingBody.However: a class that implements
IOBasedoes not need to have areadmethod implemented . From the docs:Considering all known IOstreams (
StringIO,BytesIO, etc) do have thereadimplemented, I think this is an edge case though, and not something we should worry about.