-
Notifications
You must be signed in to change notification settings - Fork 90
add BUCKET_MARKER_LOCAL config #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, kudos for proactively fixing this @bentsku ! 🚀
I tested this with a localstack docker setup an I encounter this error when setting the environment variable value to
An error occurred (InvalidParameterValueException) when calling the PublishVersion operation: CodeSHA256 (qjSNWDUILUdXq+pUZTZOla7xmgKfd3JDdy6d4i71rlk=) is different from current CodeSHA256 in $LATEST (hot-reloading-hash-not-available). Please try again with the CodeSHA256 in $LATEST. This is my plugin config: custom:
stage: local
webpack: ${file(./serverless.yml):custom.webpack}
localstack:
debug: true
edgePort: 4566
autostart: false
stages: [ local ]
lambda:
mountCode: true Added the ...
environment:
- EAGER_SERVICE_LOADING=1
- LS_LOG=debug
- PERSISTENCE=1
- BUCKET_MARKER_LOCAL=hot-reload
... Disabling versioning seems to work: provider:
versionFunctions: false
... |
Hello @Edwin-Luijten, For now, this configuration is not available yet, but once this PR is merged and a new version is published, you should be able to use Thanks for the pointer about versioning! Tagging @joe4dev here as well, feel free to correct me if I'm wrong with this. |
@bentsku Yup, I understand. I applied that patch locally to test it out =D. |
@Edwin-Luijten oh okay, sorry for the misunderstanding! And you still had that issue you reported? |
Indeed. That issue went away when I disabled function versioning. |
Seems like an issue with the LS side validation of hashes, we should not validate hot-reloading hashes. |
Adding the
BUCKET_MARKER_LOCAL
, same as LocalStack configuration, please feel free to correct the name, I don't have much inspiration! For now, the default is still__local__
but we can now set it tohot-reload
with this environment variable.