Skip to content

fix: allowing orderBy iteratees to be arrays like _.get #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: allowing orderBy iteratees to be arrays like _.get #4444

wants to merge 2 commits into from

Conversation

shubhamzanwar
Copy link

@shubhamzanwar shubhamzanwar commented Aug 25, 2019 •
edited
Loading

@jsf-clabot
Copy link

jsf-clabot commented Aug 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jdalton
jdalton reviewed Aug 25, 2019
View reviewed changes
orderBy.js
iteratees = iteratees.map((iteratee) => {
if (Array.isArray(iteratee)) {
return iteratee.join('.')
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to use join() here as array paths can capture things not possible or more complex in dot form.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give me an example of such a case, I'll try improving this PR :)

@jdalton
Copy link
Member

jdalton commented Aug 30, 2019

Thank you @shubhamzanwar!
I'm closing this in favor of #4453.

@jdalton jdalton closed this Aug 30, 2019
@jdalton jdalton added the bug label Aug 30, 2019
@jdalton jdalton added the issue bankruptcy Closing the issue/PR to start fresh label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton left review comments

Assignees
No one assigned
Labels
bug issue bankruptcy Closing the issue/PR to start fresh
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamzanwar @jsf-clabot @jdalton