Guard iframe manipulation on RunKit embed to prepare for new version. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll be shipping a major update to embeds that significantly improves performance, but unfortunately it will result in the layout being off on the lodash page due to its direct manipulation of RunKit's iframe. The good news is that the new version will behave the way it's currently changed to behave on lodash.com by default. This change just puts an if guard around the code in order to have the transition be smooth, after wee go live next week it can bee removed or other changes can be made too (there will be some new features you might be interested in). For now though, this should be a no-op currently and properly prepare the page for the update. Please do let me know if you have any questions or concerns.