pref: improve the search performance #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues #210 #212
The input action in docs search box result in page reflow and then block js, ultimately leading to search lagging.
I'm not sure what directly caused it, but uncertain height of
.doc-containerelement maybe one significant indirect cause (I have already exclude factors such as React re-rendering, event handling, and search function consumption).I speculate
.doc-mainstyleflex: 1 1 autocausing this uncertain behavior. Changing it toflex:1 1 100% | flex:1 1 100vh | flex:1 1 0indeed effective for me. Additionally, Set the.doc-containerelement height to a fixed value also works.The performance after modification:
ps: I always browsing lodash.com website in desktop as a PWA application, so I used to think the issue was due to PWA performance.😂