Skip to content

[SEMVER-MAJOR] Drop Node 0.10 and 0.12 in package.json #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2017
Merged

[SEMVER-MAJOR] Drop Node 0.10 and 0.12 in package.json #313

merged 1 commit into from
Dec 18, 2017

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Dec 7, 2017

Drop Node 0.10 and 0.12 in package.json

@dhmlau
Copy link
Member Author

dhmlau commented Dec 7, 2017

@slnode test please

1 similar comment
@dhmlau
Copy link
Member Author

dhmlau commented Dec 8, 2017

@slnode test please

@dhmlau dhmlau mentioned this pull request Dec 8, 2017
Merged
@dhmlau
Copy link
Member Author

dhmlau commented Dec 11, 2017

@slnode test please.
some server was down. kicking the test again.

@bajtos
Copy link
Member

bajtos commented Dec 12, 2017

@dhmlau note that dropping support for Node.js 0.x versions is a breaking change that must be released in a new semver-major version (ideally together with #312).

Other than that, I am fine with this change 👍

@bajtos bajtos changed the title Drop Node 0.10 and 0.12 in package.json [SEMVER-MAJOR] Drop Node 0.10 and 0.12 in package.json Dec 12, 2017
@dhmlau
Copy link
Member Author

dhmlau commented Dec 13, 2017

@bajtos , that's a good point. Thanks for the reminder!
We're having some issue with CI. @b-admike is helping to look into the problem.

@dhmlau
Copy link
Member Author

dhmlau commented Dec 17, 2017

@b-admike , do you think this is good to merge? the CI failure in strong-agent doesn't seem to be related.

@b-admike
Copy link
Contributor

@dhmlau Yeah your PR has nothing to do with the failure, and we can merge it!

@dhmlau dhmlau merged commit eca1bb8 into 2.x Dec 18, 2017
@dhmlau dhmlau deleted the update-packagejson branch December 18, 2017 15:23
@dhmlau dhmlau added this to the Sprint 51 milestone Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-admike b-admike b-admike approved these changes

Assignees
No one assigned
Labels
team-apex
Projects
None yet
Milestone
Sprint 51
Development

Successfully merging this pull request may close these issues.
3 participants
@dhmlau @bajtos @b-admike