Fixed deployment of application when it already exists in target env #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronment as DELETED or RECYCLED
✅ Deploy Preview for lowcoder-test ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the reactive chain’s .then(...) is applied regardless of the updateStatus flag by wrapping the ternary operation in parentheses.
- Changed the
updatemethod’s return so that both branches of the ternary feed into the same.then(...)chain. - Added parentheses around the conditional expression to correct operator precedence.
Comments suppressed due to low confidence (1)
server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationApiServiceImpl.java:349
- There’s no existing test covering the
updateStatus == truebranch, whereMono.empty()is followed by.then(...). Please add a unit test to verify that whenupdateStatusis true, the service still callsgetVisitorId()and completes the reactive chain as expected.
public Mono<ApplicationView> update(String applicationId, Application application, Boolean updateStatus) {
...ce/lowcoder-server/src/main/java/org/lowcoder/api/application/ApplicationApiServiceImpl.java
Show resolved
Hide resolved
ludomikula
approved these changes
May 23, 2025
ludomikula
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed deployment of application when it already exists in target env
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
xin the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
xin the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.