Skip to content

Fixed Error-list in JSON schema form #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -163,30 +163,11 @@ function transformErrors(errors: RJSFValidationError[]): RJSFValidationError[] {
if (message) {
// Error message displayed below the comp (will not be displayed when "ui:help" is set in the UI schema)
error.message = message;
// Errors displayed in the error list, not displayed when empty
error.stack = "";
}
return error;
});
}

function ErrorList(props: ErrorListProps) {
const errors = props.errors.filter((error) => error.stack);
// Avoid showing blank space when there are no errors
if (errors.length === 0) {
return <></>;
}
return (
<div style={{ color: "red" }}>
<ul>
{errors.map((error) => (
<li key={error.stack}>{error.stack}</li>
))}
</ul>
</div>
);
}

const SearchableSelectWidget = (props : any) => {
const { options, value, required, disabled, readonly, autofocus, onChange } = props;
const { enumOptions } = options;
Expand Down Expand Up @@ -300,10 +281,9 @@ let FormBasicComp = (function () {
templates={{
ObjectFieldTemplate: ObjectFieldTemplate,
ArrayFieldTemplate: ArrayFieldTemplate,
// FieldTemplate: LayoutFieldTemplate,
}}
liveValidate={true}
widgets={{ searchableSelect: SearchableSelectWidget }}
// ErrorList={ErrorList}
children={
<Button
hidden={buttonOptions?.norender}
Expand Down
Loading