Skip to content

[Fix]: backward compatibility for button, link and links column types #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2025
Merged

[Fix]: backward compatibility for button, link and links column types #1769

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2798f3f
revert back
iamfaran Jun 13, 2025
a87e00b
[Fix]: Add backward compatibility for button, link and links
iamfaran Jun 13, 2025
dfe87b3
Merge branch 'dev' of github.com:lowcoder-org/lowcoder into fix/event…
iamfaran Jun 13, 2025
e361299
fix simple column type (btn)
iamfaran Jun 13, 2025
3deda9b
Merge branch 'dev' of github.com:lowcoder-org/lowcoder into fix/event…
iamfaran Jun 13, 2025
4a2f13b
revert link column type
iamfaran Jun 13, 2025
28d3743
add backward compatibility for link type
iamfaran Jun 13, 2025
304c2c2
revert links type
iamfaran Jun 13, 2025
62285ce
add backward compatibility for links type
iamfaran Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add backward compatibility for links type
  • Loading branch information
@iamfaran
iamfaran committed Jun 13, 2025
commit 62285ce59bb8a9df18f25e70d19106c4b375ff02
23 changes: 14 additions & 9 deletions ...nt/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnLinksComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, { useState, useRef, useEffect, useCallback, useMemo } from "react";
import { default as Menu } from "antd/es/menu";
import { ColumnTypeCompBuilder } from "comps/comps/tableComp/column/columnTypeCompBuilder";
import { ActionSelectorControlInContext } from "comps/controls/actionSelector/actionSelectorControl";
import { BoolCodeControl, StringControl } from "comps/controls/codeControl";
import { manualOptionsControl } from "comps/controls/optionsControl";
import { MultiCompBuilder } from "comps/generators";
Expand All @@ -10,6 +9,9 @@ import { trans } from "i18n";
import styled from "styled-components";
import { ColumnLink } from "comps/comps/tableComp/column/columnTypeComps/columnLinkComp";
import { LightActiveTextColor, PrimaryColor } from "constants/style";
import { clickEvent, eventHandlerControl } from "comps/controls/eventHandlerControl";
import { migrateOldData } from "@lowcoder-ee/comps/generators/simpleGenerators";
import { fixOldActionData } from "comps/comps/tableComp/column/simpleColumnTypeComps";

const MenuLinkWrapper = styled.div`
> a {
Expand Down Expand Up @@ -37,11 +39,13 @@ const MenuWrapper = styled.div`
}
`;

const LinkEventOptions = [clickEvent] as const;

// Memoized menu item component
const MenuItem = React.memo(({ option, index }: { option: any; index: number }) => {
const handleClick = useCallback(() => {
if (!option.disabled && option.onClick) {
option.onClick();
option.onClick("click");
}
}, [option.disabled, option.onClick]);

Expand All @@ -58,10 +62,10 @@ const MenuItem = React.memo(({ option, index }: { option: any; index: number })

MenuItem.displayName = 'MenuItem';

const OptionItem = new MultiCompBuilder(
const OptionItemTmp = new MultiCompBuilder(
{
label: StringControl,
onClick: ActionSelectorControlInContext,
onClick: eventHandlerControl(LinkEventOptions),
hidden: BoolCodeControl,
disabled: BoolCodeControl,
},
Expand All @@ -73,17 +77,16 @@ const OptionItem = new MultiCompBuilder(
return (
<>
{children.label.propertyView({ label: trans("label") })}
{children.onClick.propertyView({
label: trans("table.action"),
placement: "table",
})}
{hiddenPropertyView(children)}
{disabledPropertyView(children)}
{children.onClick.propertyView()}
</>
);
})
.build();

const OptionItem = migrateOldData(OptionItemTmp, fixOldActionData);

// Memoized menu component
const LinksMenu = React.memo(({ options }: { options: any[] }) => {
const mountedRef = useRef(true);
Expand Down Expand Up @@ -114,7 +117,7 @@ const LinksMenu = React.memo(({ options }: { options: any[] }) => {

LinksMenu.displayName = 'LinksMenu';

export const ColumnLinksComp = (function () {
const ColumnLinksCompTmp = (function () {
const childrenMap = {
options: manualOptionsControl(OptionItem, {
initOptions: [{ label: trans("table.option1") }],
Expand All @@ -137,3 +140,5 @@ export const ColumnLinksComp = (function () {
))
.build();
})();

export const ColumnLinksComp = migrateOldData(ColumnLinksCompTmp, fixOldActionData);
Loading