Skip to content

[Feat]: file attachments support for chat component #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: feat/assistant
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize history
  • Loading branch information
iamfaran committed Jul 24, 2025
commit a01bb75d57f590cfdb3aa1a68acd5a3e5b84f794
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,14 @@ export function ChatCoreMain({
// Get messages for current thread
const currentMessages = actions.getCurrentMessages();

// Notify parent component of conversation changes
// Notify parent component of conversation changes - OPTIMIZED TIMING
useEffect(() => {
onConversationUpdate?.(currentMessages);
}, [currentMessages]);
// Only update conversationHistory when we have complete conversations
// Skip empty states and intermediate processing states
if (currentMessages.length > 0 && !isRunning) {
onConversationUpdate?.(currentMessages);
}
}, [currentMessages, isRunning]);

// Trigger component load event on mount
useEffect(() => {
Expand Down