Skip to content

Antd Upgrade #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 28, 2023
Merged

Antd Upgrade #307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f582d37
feat: upgrade antd version from v4 to v5
raheeliftikhar5 Jul 21, 2023
d09ebc3
upgrade antd dependencies
raheeliftikhar5 Jul 24, 2023
9e60dc0
refactor: replace momentJS with dayJS
raheeliftikhar5 Jul 24, 2023
a3606cb
refactor: updated dropdown
raheeliftikhar5 Jul 24, 2023
e4996df
refactor: added global instances for message, modal and notification
raheeliftikhar5 Jul 24, 2023
5baddfe
refactor: use global instances of modal, message
raheeliftikhar5 Jul 24, 2023
47c1723
refactor: antd component changes
raheeliftikhar5 Jul 24, 2023
4dbbd23
fix: fixed unit test
raheeliftikhar5 Jul 24, 2023
020d569
fix: datepicker and timepicker issues fixed
raheeliftikhar5 Jul 25, 2023
4d93ea2
Merge branch 'lowcoder-org:main' into antd-upgrade
raheeliftikhar5 Jul 25, 2023
501e00d
fix: fixed popover and collapse
raheeliftikhar5 Jul 26, 2023
a19df59
fix: updated timeline
raheeliftikhar5 Jul 26, 2023
9f7a49b
fix: UI fixes
raheeliftikhar5 Jul 26, 2023
b025eba
Merge branch 'main' into antd-upgrade
FalkWolsky Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: added global instances for message, modal and notification
  • Loading branch information
@raheeliftikhar5
raheeliftikhar5 committed Jul 24, 2023
commit e4996df2f2d055c45814447d427fd22ecbeffdde
18 changes: 18 additions & 0 deletions client/packages/lowcoder-design/src/components/GlobalInstances.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { App } from 'antd';
import type { MessageInstance } from 'antd/es/message/interface';
import type { ModalStaticFunctions } from 'antd/es/modal/confirm';
import type { NotificationInstance } from 'antd/es/notification/interface';

let messageInstance: MessageInstance;
let notificationInstance: NotificationInstance;
let modalInstance: Omit<ModalStaticFunctions, 'warn'>;

export default () => {
const staticFunction = App.useApp();
messageInstance = staticFunction.message;
modalInstance = staticFunction.modal;
notificationInstance = staticFunction.notification;
return null;
};

export { messageInstance, notificationInstance, modalInstance };
1 change: 1 addition & 0 deletions client/packages/lowcoder-design/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export * from "./components/CustomModal";
export * from "./components/Drawer";
export * from "./components/Dropdown";
export * from "./components/ExternalLink";
export * from "./components/GlobalInstances";
export * from "./components/Input";
export * from "./components/Label";
export * from "./components/Menu";
Expand Down
17 changes: 13 additions & 4 deletions client/packages/lowcoder/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ConfigProvider } from "antd";
import { App, ConfigProvider } from "antd";
import {
ALL_APPLICATIONS_URL,
APP_EDITOR_URL,
Expand Down Expand Up @@ -46,6 +46,7 @@ import { isFetchUserFinished } from "redux/selectors/usersSelectors";
import { SystemWarning } from "./components/SystemWarning";
import { getBrandingConfig, getSystemConfigFetching } from "./redux/selectors/configSelectors";
import { buildMaterialPreviewURL } from "./util/materialUtils";
import GlobalInstances from 'components/GlobalInstances';

const LazyUserAuthComp = React.lazy(() => import("pages/userAuth"));
const LazyInviteLanding = React.lazy(() => import("pages/common/inviteLanding"));
Expand All @@ -54,9 +55,17 @@ const LazyComponentPlayground = React.lazy(() => import("pages/ComponentPlaygrou
const LazyDebugComp = React.lazy(() => import("./debug"));
const LazyDebugNewComp = React.lazy(() => import("./debugNew"));

const Wrapper = (props: { children: React.ReactNode }) => {
return <ConfigProvider locale={getAntdLocale(language)}>{props.children}</ConfigProvider>;
};
const Wrapper = (props: { children: React.ReactNode }) => (
<ConfigProvider
theme={{ hashed: false }}
locale={getAntdLocale(language)}
>
<App>
<GlobalInstances />
{props.children}
</App>
</ConfigProvider>
);

type AppIndexProps = {
isFetchUserFinished: boolean;
Expand Down