Skip to content

Add Missing Existence Check For dynamicParamsConfig That Causes FireBase Conenctor Query Run Failure #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2023
+1 −1
Merged

Add Missing Existence Check For dynamicParamsConfig That Causes FireBase Conenctor Query Run Failure #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add existence check for dynamicParamsConfig 
- Add an existence check to fix invalid traversal of dataSourceConfig.dynamicParamsConfig() in case of null dataSourceConfig.dynamicParamsConfig value
  • Loading branch information
@aq-ikhwa-tech
aq-ikhwa-tech committed Jul 29, 2023
commit 2cc62cc0c83dec853301a9f79ce01071336fb13e
2 changes: 1 addition & 1 deletion server/node-service/src/services/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export async function runPluginQuery(

//forward cookies
context.forEach(({ key, value }) => {
if (key in dataSourceConfig.dynamicParamsConfig) {
if (dataSourceConfig.dynamicParamsConfig && key in dataSourceConfig.dynamicParamsConfig) {
const valueKey = `${key}.value`;
dataSourceConfig.dynamicParamsConfig[valueKey] = value[0].value
}
Expand Down