Skip to content

Fixed table header + Handle editor's right panel foldable section in search #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Fixed table header + Handle editor's right panel foldable section in search #535

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38fe46f
feat: fixed header option
raheeliftikhar5 Nov 30, 2023
2bf6d87
fix: use window inner width instead of screen width
raheeliftikhar5 Nov 30, 2023
fe1affe
fix: show component sectios open in right panel in search state
raheeliftikhar5 Nov 30, 2023
18e49ca
fix: replace maxHeight with auto/fixed Height
raheeliftikhar5 Nov 30, 2023
5e73943
fix: small fix
raheeliftikhar5 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: small fix
  • Loading branch information
@raheeliftikhar5
raheeliftikhar5 committed Nov 30, 2023
commit 5e73943f33e54e9c3d69fcfda42267f9f5a40bd0
7 changes: 6 additions & 1 deletion client/packages/lowcoder/src/comps/comps/tableComp/tableCompView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ type CustomTableProps<RecordType> = Omit<TableProps<RecordType>, "components" |
columnsStyle: TableColumnStyleType;
fixedHeader: boolean;
height?: number;
autoHeight?: boolean;
};

function TableCellView(props: {
Expand Down Expand Up @@ -539,7 +540,9 @@ function ResizeableTable<RecordType extends object>(props: CustomTableProps<Reco
columns={columns}
scroll={{
x: COL_MIN_WIDTH * columns.length,
y: props.fixedHeader && props.height ? `${props.height - 100}px` : undefined,
y: props.fixedHeader && props.height && !props.autoHeight
? `${props.height - 100}px`
: undefined,
}}
></Table>
);
Expand Down Expand Up @@ -581,6 +584,7 @@ export function TableCompView(props: {
() => compChildren.dynamicColumnConfig.getView(),
[compChildren.dynamicColumnConfig]
);
const autoHeight = compChildren.autoHeight.getView();
const columnsAggrData = comp.columnAggrData;
const expansion = useMemo(() => compChildren.expansion.getView(), [compChildren.expansion]);
const antdColumns = useMemo(
Expand Down Expand Up @@ -705,6 +709,7 @@ export function TableCompView(props: {
size={compChildren.size.getView()}
tableLayout="fixed"
height={height}
autoHeight={autoHeight}
loading={
loading ||
// fixme isLoading type
Expand Down