Skip to content

Fallback for missing Translation fields #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

We do use translation files. However, when developers add features to Lowcoder, they may miss adding these translation keys to "every" language file. We currently have English and Chinese language files and need to excuse that missing keys were the problem. We did fix the root cause now and should not see this anymore. Instead, there will be a small message in the console log as well in the place of the missing translation. So we can find these faster and add them to the translation files then.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit cb27ed3
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/659eec4e8e2f2400085834a3
😎 Deploy Preview https://deploy-preview-625--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit dfd3ded into main Jan 10, 2024
@FalkWolsky FalkWolsky deleted the feature/translations branch January 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant