Skip to content

Remove .DS_Store file and duplicate in .gitignore #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2024
Merged

Remove .DS_Store file and duplicate in .gitignore #687

merged 2 commits into from
Feb 18, 2024

Conversation

yofriadi
Copy link

Proposed changes

Remove unneded file form git tracking.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Removed also from git cache, hopefully not showing any changes further to this file.

@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024 •
edited
Loading

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 644f382

@FalkWolsky
Copy link
Contributor

Hello yofriadi, we were very happy to see your contribution.
Our general approach is to merge first do /dev and test. Later we merge then for a release to /main.
We will rebase therefor your PR and approve it.

@FalkWolsky FalkWolsky changed the base branch from main to dev February 18, 2024 10:28
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 644f382

FalkWolsky
FalkWolsky approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! It is truly good to clean-up...

@FalkWolsky FalkWolsky merged commit b4e67c3 into lowcoder-org:dev Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FalkWolsky FalkWolsky FalkWolsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yofriadi @FalkWolsky