Skip to content

Module loading issues #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Module loading issues #781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f58bffd
add notifications for apps loading with sdk
raheeliftikhar5 Mar 29, 2024
264b2f0
added delay for queries trigger on page load
raheeliftikhar5 Mar 30, 2024
383c716
Merge branch 'dev' into module_loading_issues
FalkWolsky Apr 1, 2024
365e46f
Merge branch 'dev' into module_loading_issues
FalkWolsky Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added delay for queries trigger on page load
  • Loading branch information
@raheeliftikhar5
raheeliftikhar5 committed Mar 30, 2024
commit 264b2f04b737fde334cbb424970b5ebe188cf609
17 changes: 13 additions & 4 deletions client/packages/lowcoder-design/src/components/ScrollBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import styled from "styled-components";
import { DebouncedFunc } from 'lodash'; // Assuming you're using lodash's DebouncedFunc type


const ScrollBarWrapper = styled.div<{ hidePlaceholder?: boolean }>`
const ScrollBarWrapper = styled.div<{ $hideplaceholder?: boolean }>`
min-height: 0;
height: 100%;
width: 100%;
Expand Down Expand Up @@ -37,7 +37,7 @@ const ScrollBarWrapper = styled.div<{ hidePlaceholder?: boolean }>`
bottom: 10px;
}

${props => props.hidePlaceholder && `
${props => Boolean(props.$hideplaceholder) && `
.simplebar-placeholder {
display: none !important;
}
Expand All @@ -54,11 +54,20 @@ interface IProps {
scrollableNodeProps?: {
onScroll: DebouncedFunc<(e: any) => void>;
};
hidePlaceholder?: boolean;
$hideplaceholder?: boolean;
hideScrollbar?: boolean;
}

export const ScrollBar = ({ height = "100%", className, children, style, scrollableNodeProps, hideScrollbar = false, ...otherProps }: IProps) => {
export const ScrollBar = ({
height = "100%",
className,
children,
style,
scrollableNodeProps,
hideScrollbar = false,
$hideplaceholder = false,
...otherProps
}: IProps) => {
// You can now use the style prop directly or pass it to SimpleBar
const combinedStyle = { ...style, height }; // Example of combining height with passed style

Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder-design/src/components/Section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const BaseSection = (props: ISectionConfig<ReactNode>) => {
const { compName, state, toggle } = useContext(PropertySectionContext);
const open = props.open !== undefined ? props.open : name ? state[compName]?.[name] !== false : true;

console.log("open", open, props.open);
// console.log("open", open, props.open);

const handleToggle = () => {
if (!name) {
Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/comps/moduleContainerComp/moduleLayoutComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class ModuleLayoutComp extends ModuleLayoutCompBase implements IContainer
const rowCount = this.children.containerRowCount.getView();
return (
<div>
<ScrollBar style={{ height: "100%", margin: "0px", padding: "0px" }} hidePlaceholder={false}>
<ScrollBar style={{ height: "100%", margin: "0px", padding: "0px" }} $hideplaceholder={false}>
<ModuleLayoutView
positionParams={this.children.positionParams.getView()}
containerSize={this.children.containerSize.getView()}
Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/queries/queryComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ function QueryView(props: QueryViewProps) {
) {
setTimeout(() => {
comp.dispatch(deferAction(executeQueryAction({})));
});
}, 100);
}
}, []);

Expand Down