Skip to content

Commit bd718e4

Browse files
authored
Merge pull request GoogleCloudPlatform#901 from GoogleCloudPlatform/speech_unicode
Translate unicode
2 parents 0854972 + 5062b2d commit bd718e4

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

translate/cloud-client/snippets.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import argparse
2525

2626
from google.cloud import translate
27+
import six
2728

2829

2930
def detect_language(text):
@@ -73,12 +74,13 @@ def translate_text_with_model(target, text, model=translate.NMT):
7374
"""
7475
translate_client = translate.Client()
7576

77+
if isinstance(text, six.binary_type):
78+
text = text.decode('utf-8')
79+
7680
# Text can also be a sequence of strings, in which case this method
7781
# will return a sequence of results for each text.
7882
result = translate_client.translate(
79-
text,
80-
target_language=target,
81-
model=model)
83+
text, target_language=target, model=model)
8284

8385
print(u'Text: {}'.format(result['input']))
8486
print(u'Translation: {}'.format(result['translatedText']))
@@ -94,11 +96,13 @@ def translate_text(target, text):
9496
"""
9597
translate_client = translate.Client()
9698

99+
if isinstance(text, six.binary_type):
100+
text = text.decode('utf-8')
101+
97102
# Text can also be a sequence of strings, in which case this method
98103
# will return a sequence of results for each text.
99104
result = translate_client.translate(
100-
text,
101-
target_language=target)
105+
text, target_language=target)
102106

103107
print(u'Text: {}'.format(result['input']))
104108
print(u'Translation: {}'.format(result['translatedText']))

translate/cloud-client/snippets_test.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,10 @@ def test_translate_text(capsys):
4040
snippets.translate_text('is', 'Hello world')
4141
out, _ = capsys.readouterr()
4242
assert u'Halló heimur' in out
43+
44+
45+
def test_translate_utf8(capsys):
46+
text = u'나는 파인애플을 좋아한다.'
47+
snippets.translate_text('en', text)
48+
out, _ = capsys.readouterr()
49+
assert u'I like pineapple.' in out

0 commit comments

Comments
 (0)