fix(runfiles): fixed some issues with temporary directory creation #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Been reviewing this offline with Jaden. |
The directories we were creating weren't random, so it was possible tha two Node actions could share the same directory and one could delete it before the other. Also, when catching process events like `uncaughtException` and signal events, we need explicitly stop the process (and make sure we return the correct code). In the case of `uncaughtException`, we also need to handle the error thrown in the same way Node.js would've. Doing clean up work seems to be an very difficult problem in Node (hence the existence of `https://github.com/nodejs/node/issues/20804`), so I've decided to just catch `exit` for the time being. Sure, we may leak temporary directories if a certain signal is sent, but I think the risk of not handling signals correctly outweighs the risk of leaking temporary directories.
9988816 to
dd3613c
Compare
jjudd
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directories we were creating weren't random, so it was possible tha two Node actions could share the same directory and one could delete it before the other.
Also, when catching process events like
uncaughtExceptionand signal events, we need explicitly stop the process (and make sure we return the correct code). In the case ofuncaughtException, we also need to handle the error thrown in the same way Node.js would've. Doing clean up work seems to be an very difficult problem in Node (hence the existence ofhttps://github.com/nodejs/node/issues/20804), so I've decided to just catchexitfor the time being. Sure, we may leak temporary directories if a certain signal is sent, but I think the risk of not handling signals correctly outweighs the risk of leaking temporary directories.