refactor(*): simplify paths to the binary files #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
Bundle ReportChanges will decrease total bundle size by 52 bytes (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: website-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #401 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 422 424 +2
=========================================
+ Hits 422 424 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the structure of binary files by moving them out of src into top-level bin or script directories, updating path resolutions, build scripts, and CI workflows accordingly.
- Moved
binandscriptfolders to package roots and updatedget*Pathutilities - Simplified
cp.mjsbuild helper and adjustedpackage.jsonbuild & chmod scripts - Updated documentation links and GitHub Actions workflows to reflect new paths
Reviewed Changes
Copilot reviewed 11 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/apis/clang-format-git-python.md | Updated Markdown link to the relocated script path |
| scripts/cp.mjs | Removed unnecessary recursive flag from cpSync |
| packages/clang-format-node/src/utils/getClangFormatPath.js | Adjusted path resolution to new bin directory |
| packages/clang-format-node/package.json | Updated files, build, and chmod scripts |
| packages/clang-format-git/src/utils/getGitClangFormatPath.js | Adjusted path resolution to new bin directory |
| packages/clang-format-git/package.json | Updated files, build, and chmod scripts |
| packages/clang-format-git-python/src/utils/gitClangFormatPath.js | Updated documentation link and path resolution |
| packages/clang-format-git-python/src/utils/gitClangFormatPath.test.js | Updated test to expect new path depth |
| packages/clang-format-git-python/package.json | Updated files, build, and chmod scripts |
| .github/workflows/test-cross-platform.yml | Updated Docker copy paths to new bin locations |
| .github/workflows/llvm-build-bump-pr.yml | Updated artifact download paths to new directories |
lumirlumir
added a commit
that referenced
this pull request
Jul 14, 2025
…ch`) (#404) ## Release Information: `v1.3.5` New release of `lumirlumir/npm-clang-format-node` has arrived! 🎉 This PR bumps the package versions from `v1.3.4` to `v1.3.5` (`patch`). See [Actions](https://github.com/lumirlumir/npm-clang-format-node/actions/runs/16264909140) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-clang-format-node` | | SEMVER | `patch` | | Pre ID | `canary` | | Short SHA | df49101 | | Old Version | `v1.3.4` | | New Version | `v1.3.5` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🐛 Bug Fixes * fix(*): drop `shx` and replace it with Node.js native script by @lumirlumir in #402 ### 🛠️ Builds * build(*): add `cp.mjs` script for file copying and update build scripts by @lumirlumir in #400 ### ♻️ Code Refactoring * refactor(*): simplify paths to the binary files by @lumirlumir in #401 ### ⬆️ Dependency Updates * chore(deps-dev): bump eslint from 9.30.1 to 9.31.0 by @dependabot[bot] in #403 **Full Changelog**: v1.3.4...v1.3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes the directory structure of several packages (
clang-format-git,clang-format-git-python, andclang-format-node) to simplify paths and improve consistency. It also updates related scripts, tests, and documentation to reflect these changes.Directory Structure Updates:
.github/workflows/llvm-build-bump-pr.ymland.github/workflows/test-cross-platform.yml: Updated artifact paths forclang-format-git,clang-format-git-python, andclang-format-nodeto removesrcdirectories and directly referencebinorscriptdirectories. [1] [2]Package Configuration Changes:
packages/clang-format-git/package.json,packages/clang-format-git-python/package.json, andpackages/clang-format-node/package.json: Updatedfilesarrays to include new directories (binorscript) and modifiedbuildandchmodscripts to reflect the updated directory structure. [1] [2] [3] [4] [5] [6]Code Updates:
packages/clang-format-git/src/utils/getGitClangFormatPath.jsandpackages/clang-format-node/src/utils/getClangFormatPath.js: Adjusted path resolution logic to account for the removal ofsrcdirectories. [1] [2]packages/clang-format-git-python/src/utils/gitClangFormatPath.jsandpackages/clang-format-git-python/src/utils/gitClangFormatPath.test.js: Updated path references forgit-clang-formatscript and corresponding tests. [1] [2]Documentation and Script Updates:
website/docs/apis/clang-format-git-python.md: Updated documentation to reflect the new path for thegit-clang-formatscript.scripts/cp.mjs: Removed therecursiveoption from thecpSyncfunction since it is no longer needed for the updated directory structure.