introduce appendLines method in IO. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds appendLines to the IO api, which lets users easily append a sequence of strings to a file that already exists.
Also refactors the appendLines method to use the newly introduced function.
|
I guess we should have trailing "\n" in the line-writers. |
|
Added a trailing newline @bjornregnell |
bjornregnell
reviewed
Jun 6, 2024
| @@ -51,7 +51,7 @@ object IO: | |||
| * @param enc the encoding of the file. | |||
| * */ | |||
| def saveLines(lines: Seq[String], fileName: String, enc: String = "UTF-8"): Unit = | |||
| saveString(lines.mkString("\n"), fileName, enc) | |||
| saveString(lines.mkString("\n") + "\n", fileName, enc) | |||
There was a problem hiding this comment.
I think if lines are empty it should not write so better use mkString("", "\n", "\n") see docs for mkString to double-check the behavior or test in repl.
bjornregnell
reviewed
Jun 6, 2024
| * @param enc the encoding of the file. | ||
| * */ | ||
| def appendLines(lines: Seq[String], fileName: String, enc: String = "UTF-8"): Unit = | ||
| appendString(lines.mkString("\n"), fileName, enc) |
There was a problem hiding this comment.
also here it should be mkString("","\n","\n") I think, but check that it works as expected.
There was a problem hiding this comment.
I'll merge this and then fix the correct behavior wen empty in a later commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds appendLines to the IO api, which lets users easily append a sequence of strings to a file that already exists.
Solves #45 .